yanny7 / YTech

YTech is tech mod based on real life, increasing difficulty on early game.
GNU General Public License v3.0
4 stars 2 forks source link

KubeJS request #14

Open deftesthawk opened 2 days ago

deftesthawk commented 2 days ago

I'm so thankful that you provide KubeJS support, I have something that I think would be a great addition if you're okay with adding it.

  1. Add a chance value variable to the block hit recipe it could also have a optional secondary output variable for if it fails and if one isn't provided it wouldn't give anything.
deftesthawk commented 2 days ago

Just realized that the tree stump doesn't have support so I added it to the list and that to Workspace Crafting doesn't have a tool option.

yanny7 commented 2 days ago

Tree stump is missing in Wiki but it's implemented. For workspace crafting it's impossible to set tool.

deftesthawk commented 2 days ago

Okay, thanks. I'll see if I can work out how todo the tree stump recipes.

yanny7 commented 2 days ago

Wiki was updated, check https://github.com/yanny7/YTech/wiki/KubeJS#chopping

yanny7 commented 2 days ago

I think that changing/removing recipes by type it's up to KubeJS, not mod integration

event.remove({ type: 'ytech:chopping' })
deftesthawk commented 1 day ago

I just figured that out xD

deftesthawk commented 1 day ago

Added a new request, I was adding new modded wood types to the "Chopping" recipe list when I realized they all give 1 item. I tried testing to see if there was a way of adding an output count but couldn't find a way so I'm assuming there's not. It would also be a nice addition to the "Block Hit" recipes

yanny7 commented 1 day ago

This is how you set output count

event.recipes.ytech.chopping('5x minecraft:diamond', Item.of("minecraft:oak_log"), Item.of("ytech:flint_axe"))//.hitCount(10);

please check KubeJS doc first

deftesthawk commented 1 day ago

Sorry, I missed that part on the wiki. Thought it would have been. event.recipes.ytech.chopping('minecraft:diamond, 2', Item.of("minecraft:oak_log"), Item.of("ytech:flint_axe"))//.hitCount(10);

I’ll make sure to double check in future, sorry again

deftesthawk commented 1 day ago

If it's possible maybe adding .hitCount(4) to the hammer recipe type, as it would feel immersive to hammer the item multiple times on the anvil.

I also noticed that the golden shears name is display as "item.ytech.golden_shears" I created a resource pack with the lang file to fix it on my end but thought it might be worth mentioning

yanny7 commented 23 hours ago

This is already available in v0.9.0 released two hours ago :)

deftesthawk commented 23 hours ago

Thank you! Looks like a cool update :)

deftesthawk commented 23 hours ago

Not sure if this was intentional but the stone mortar and pestle recipe requires #minecraft:planks

yanny7 commented 10 hours ago

Yes it's intentional, but maybe it should be renamed to wooden mortar and pestle... Stone was gated, so I had to replace stone with something else.

deftesthawk commented 10 hours ago

Ah that makes sense, yeah it seemed out of place with the new recipes due to all but that one requiring the material they’re named after. Wooden mortar and pestle would definitely fit the recipe