Closed emil14 closed 1 year ago
At a quick glance, it looks as though the wg.Add(1)
(on line 43) needs to happen outside of the goroutine creation in commit a654684 @yanue
Actually, I don't see how making the PedersenHash
function concurrent like this could work anyway...
Also, the extended Euclidean algorithm implementation (igcdex()
) looks broken. E.g. the first if
statement is comparing the same conditions.
I've forked the project for now (tpunt/starkex) to apply the fixes, since the owner is not currently around. Happy to create PRs to fix things in this repo when the owner is back (I really don't want to maintain a fork of this).
Awesome! Thank you so much @tpunt
Is this library still works? Could you please admit it? It looks like I didn't change anything in my code but it's not working any longer.
This is how I use it
req.ClientId, // "1"
thoughUPD:
clientID
if generated now, it wasn't the problemI think you last commit where you've added concurrency to crypto stuff broke something. Rollback to the prev version fixed the problem