yanus171 / Handy-News-Reader

Handy News Reader is a light and modern Android feed reader, based on Flym News Reader
Other
194 stars 23 forks source link

Filter: 'Accept' and 'Reject' don't work together #127

Closed bcm314 closed 1 year ago

bcm314 commented 5 years ago

'Accept' overrides 'Reject' is not working as it should be.

When you have at least ONE rule of kind 'Accept', all 'Reject' rules are completely ignored: as a result you get only articles fitting the 'Accept' rules.

Maybe better say: 'only fulfilled Accept' overrides 'Reject'

Make an example, how it should work: assume, there is a feed with a lot of news - you don't like to see "sport" articles, but maybe there is one sport you like to see (maybe football). so you create two rules:

In the current version, you'll see only articles with "football", not any other you like to see. The correct procedure should be the following: for each article, check if it fulfill any accept-rule a) if so, add this article to the list: (fulfilled)'Accept' overrides 'Reject', 'Reject' not needed to check, in such cases b) BUT (!!!) if not, check if it fulfill any reject-rule and if not any, add also this article.

(Or vice versa: first check all reject-rules and all articles filtered out check if any accept-rule override it)

yanus171 commented 5 years ago

Now Accept means accept only, so where will be loaded only articles matching any of accept rules. May be there is a need for more information about it in filter dialog. And this is a common case for a filter.

In your case the meaning of Accept rule changes significally. It's look like another filter mode. Do we really need it?

Maybe just block reject rule if accept is set?