search

yanus171 / Handy-News-Reader

Handy News Reader is a light and modern Android feed reader, based on Flym News Reader
Other
194 stars 22 forks source link

Never-ending "Start Auto Refresh" Cycle #765

Open touwys opened 2 years ago

touwys commented 2 years ago

Describe the bug

  1. "Start Auto Refresh" goes into perpetual mode, and cannot be cancelled by means any other than rebooting the device.
  2. This behaviour was noticed over several releases, not just the current one.

Steps to reproduce the behaviour:

  1. "Start Auto refresh cycle manually. (In this case, it is not set to refresh automatically).
  2. The refresh cycle continues indefinitely — even when the "Cancel" button (X) is tapped.
  3. Closing the application and restarting it does not stop the refresh cycle.
  4. Rebooting the device provides is the only way to stop the refresh cycle.

Expected behaviour

Tapping the Cancel button (X) should stop the refresh cycle within almost immediately.

Screenshots

https://user-images.githubusercontent.com/65730626/160440727-bd505079-46c3-46fc-b968-66cf6d67db07.mp4

Device — Tablet:

• Huawei Mediapad M5 Lite Model: BAH2-L09 • Android Version : 8.0.0 • Device Total Internal memory : 24958189568 • Android Browser Firefox 68.1.1 • Android File Manager X-plore 4.28.32 • Handy News Reader Release 0.16.22_252

—

yanus171 commented 2 years ago

It's likely due to one of regex filters applied to particular text in some feed. String processing with regex may hang. Try to find this filter and turn it off (uncheck regex checkbox). Also you have no need to rebooting the device. Just stop the app from system settings and run it again

touwys commented 2 years ago

Thank you for the pointers. It should be noted that I do not apply regex filters anywhere, because I do not know how to. Furthermore, I did "Force Stop" the app using the device system settings, but this does not consistently turn off the hanging Auto Refresh cycle. The only reliable way to stop it is to reboot the device.

It appears to me as if the following feed might be causing the hanging Auto Refresh, because the refresh cycle usually appears to hang right there — as interpreted from "Detailed progress info technical info". Both the following feeds URL's work just fine in the desktop news reader, but they will now not add any feed articles in Handy news Reader (while it previously did very work well over a long time). To check it, I deleted the feed, and then added it back again, using these two feed addresses interchangeably — but to no avail:

  1. http://www.stationgossip.com/feeds/posts/default?alt=rss =RSS [was always used as the default feed until now]
  2. http://www.stationgossip.com/feeds/posts/default =Atom [used for testing]

———

yanus171 commented 2 years ago

Try to turn off auto refresh for that feed. Check if there would be no hanging

touwys commented 2 years ago

Auto refresh is not enabled for this feed, nor for any other.

yanus171 commented 2 years ago

So the issue occurs when you tap Start auto refresh but no articles has auto refresh enabled?

touwys commented 2 years ago

Yes.

The two screen videos of the same feed in its manual refresh cycle, were taken about 10 minutes apart. The 1st video show the start of the refresh cycle, and it was still busy 10 minutes later — it did not respond to the cancel refresh tap X

— Video 1

https://user-images.githubusercontent.com/65730626/161037905-eecab05e-2582-47fc-abbf-6cb5464d6406.mp4

— Video 2

https://user-images.githubusercontent.com/65730626/161037935-6de2da90-4259-41fe-bbac-26b572e5ca3b.mp4

—

touwys commented 2 years ago

The feed for http://www.stationgossip.com was deleted, since the refresh cycle usually started to hang right there. The result is that the refresh cycle is now proceeding as expected.

Recreating this feed, then reintroduced the issue. Deleting it once more, fixed it again.

It can also be noted that HNR was unable to find the news feed for this site in the usual manner. Using the internal search for it, produces no results.

touwys commented 2 years ago

Repeated testing confirms the feed http://www.stationgossip.com/feeds/posts/default?alt=rss (as well as its Atom counterpart) is related to this issue. Can this feed be restored to not cause the refresh cycles to hang anymore? It displays problem-free in the Firefox browser installed on the mobile device, plus in the RSS feed reader installed on the desktop PC.

yanus171 commented 2 years ago

When I marked the issue with Accepted label I managed to reproduce the issue on my phone, so I need no more additional info (if I don't ask for it explicitly).

touwys commented 2 years ago

After deleting these two feeds that are related to this issue, I skipped a few releases and then added the two to release v0.17.1. Neither feed will display the list of articles that are known to be present on their respective web pages:

  1. http://www.stationgossip.com/feeds/posts/default?alt=rss
  2. http://www.stationgossip.com/feeds/posts/default
touwys commented 2 years ago

Auto refresh is not enabled for this feed, nor for any other.