yanwsh / videojs-panorama

a plugin for videojs run a full 360 degree panorama video.
http://yanwsh.github.io/videojs-panorama/
Other
488 stars 160 forks source link

Js error with v4 #3

Closed zang closed 8 years ago

zang commented 8 years ago

With v5, the plugin works fine so far. With v4, we got the following error of running the demo on Chrome: videojs-panorama.v4.min.js:1 Uncaught TypeError: Cannot read property 'el' of undefined

yanwsh commented 8 years ago

Hey, could you provide the detail how can I reproduce this issue? Which browser did you find the issue? If you can setup a demo page for me to debug the issue will be much helpful. Thanks for interesting.

zang commented 8 years ago

Thanks @yanwsh and I will provide more details early next week. Cool plugin btw :)

yanwsh commented 8 years ago

Sure, thanks for interesting and let me know anything i can help.

zang commented 8 years ago

I used the html of your demo page and changed to v4 and got the above error. :) Let me know if you need more information pls.

yanwsh commented 8 years ago

Oh, I got the issue. You have to use develop version of videojs 4. You can download videojs 4 source code here.

I also updated my documentation and setup a demo page for videojs 4.

Let me know if you have any questions.

zang commented 8 years ago

thanks @yanwsh

adamck commented 8 years ago

@yanwsh Is there any fundamental reason this shouldn't work with the production-ready version of video.js?

yanwsh commented 8 years ago

Hello, it's a production version, just should be not minified. In videojs 4, the minified version rename the API name, but my plugin need some API calling, so we can't use minified version directly. But you can download the unminified version and minified on your end. If you really want to use production-ready version, you can use videojs 5.

Let me know if you have any questions.

yanwsh commented 8 years ago

@zang @adamck I updated source code, you don't have to use develop version, you can use production version now, let me know if you have any questions.

zang commented 8 years ago

Thanks a lot @yanwsh , it works fine. :)