search

yanwsh / videojs-panorama

a plugin for videojs run a full 360 degree panorama video.
http://yanwsh.github.io/videojs-panorama/
Other
483 stars 160 forks source link

needsUpdate in player's paused state #82

Open kuehn-sba opened 7 years ago

kuehn-sba commented 7 years ago

Videojs normal behaviour is an update in pause state. So can you please remove the paused condition in animate function (seen in L591 in videojs-panorama.v5)?:

if (!this.player().paused()) {

thx..

yanwsh commented 7 years ago

This issue should be fixed.

kuehn-sba commented 7 years ago

no it isn't. There is still "if (!this.player().paused())", which will not update frames in pause mode (for seeking, scrubbing a.s.o.)

yanwsh commented 7 years ago

Why do you want to update when video paused?

Rendering 3d video is super expensive, it exhaust lots of CPU and memory, so my idea is to avoid rendering if video paused.

But i add additional code to check if user seek the videojs progressbar, so if user scroll the progress bar, it will also updated.

So let me know in which condition its not working.

Thanks.

yanwsh commented 7 years ago

Wait, i double check, it's not working now. It's a bug. Thank you.

yanwsh commented 6 years ago

This is supported on v1.0.0, please check here