search

yanyiwu / limonp

C++ headers(hpp) library with Python style.
MIT License
125 stars 43 forks source link

remove a inline declaration because function of variable parameter cann't define to inline. #8

Closed webary closed 8 years ago

webary commented 8 years ago
  1. .\include\limonp\StringUtil.hpp|28|: function 'std::string limonp::StringFormat(const char*, ...)' can never be inlined because it uses variable argument lists.
  2. the format of some comments in the main function doesn't match the real output of the code.
yanyiwu commented 8 years ago
  1. Thanks very much. But Why I need the inline is not for the function to be inlined, just only to make compiler happy when multi source code include this xxx.hpp . If any function in xxx.hpp without prefix inline modifier, compiling would fail, just like https://travis-ci.org/yanyiwu/limonp/jobs/117288862
  2. You are right. But I can not merge this pull request until you fix the problem in https://travis-ci.org/yanyiwu/limonp/jobs/117288862
webary commented 8 years ago

Okay, I get it and fix the error in my fork.