chore: support multi-arch and prebuild binaries correctly

yanyiwu / nodejieba

"结巴"中文分词的Node.js版本

MIT License

3.05k stars 277 forks source link

chore: support multi-arch and prebuild binaries correctly #230

Closed yeliex closed 10 months ago

yeliex commented 10 months ago

this pr fix invalid configuration of github ci test and release, including support arm64 and run running in correctly arch os.

it should build pre-build binaries as expected and upload them to github node registry without specify token manually.

test case in my repo: https://github.com/yeliex/nodejieba/actions/runs/7206729058

EDIT: mark as draft currently because cannot build for arm64 directly, should use docker to support cross-compile

yeliex commented 10 months ago

@yanyiwu @Mister-Hope review please

as far as I am concerned, it is really heavy for a such simply node repo to use pnpm(it cause cannot support node<16) and rollup(it just has a ts file only, tsc or swc is enough)