yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
https://yanyongyu.github.io/githubkit/
MIT License
204 stars 25 forks source link

Feature: support app jwt auth using client id #129

Closed yanyongyu closed 2 months ago

yanyongyu commented 2 months ago

Client ID is recommended now when generating jwt token.

Reference: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 17.69%. Comparing base (68ea192) to head (5d69109). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
githubkit/auth/app.py 47.05% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ========================================== - Coverage 17.69% 17.69% -0.01% ========================================== Files 4834 4834 Lines 223288 223343 +55 ========================================== + Hits 39512 39519 +7 - Misses 183776 183824 +48 ``` | [Flag](https://app.codecov.io/gh/yanyongyu/githubkit/pull/129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ju4tCode) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/yanyongyu/githubkit/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ju4tCode) | `17.69% <47.05%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ju4tCode#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.