yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
https://yanyongyu.github.io/githubkit/
MIT License
204 stars 25 forks source link

Fix: make query, header, cookie params keyword only #167

Closed yanyongyu closed 1 week ago

yanyongyu commented 1 week ago

some optional query params may come before required params. this will cause syntax error.

such as:

    def get_time_stats(
        self,
        org: str,
        min_timestamp: str,
        max_timestamp: Missing[str] = UNSET,
        timestamp_increment: str,
        *,
        headers: Optional[dict[str, str]] = None,
    ) -> Response[list[ApiInsightsTimeStatsItems], list[ApiInsightsTimeStatsItemsType]]:
        """See also: https://docs.github.com/rest/orgs/api-insights#get-time-stats"""