search

yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
https://yanyongyu.github.io/githubkit/
MIT License
177 stars 25 forks source link

Feature: allow integer app id #23

Closed dosisod closed 1 year ago

dosisod commented 1 year ago

Since GitHub application IDs are always integers, it would be nice if the AppInstallationAuthStrategy (and similar) classes allowed for int types in addition to str. We could just replace str with int, but that wouldn't be backwards compatible, so I decided to just keep both. I can update that though if only using int is preferred.

dosisod commented 1 year ago

Thanks for catching that, I write mostly Python 3.10+ code so I'm used to using type unions

yanyongyu commented 1 year ago

Python 3.10+ typing is so convenient 👍🏻