search

yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
https://yanyongyu.github.io/githubkit/
MIT License
177 stars 25 forks source link

Feature: Change to Pydantic 2 compatible openapi schema parser #40

Closed zegl closed 1 year ago

zegl commented 1 year ago

I've read through #38 and got excited to check and see what it would take to add support for Pydantic 2.

The first issue I encountered was that openapi-schema-pydantic only supports Pydantic 1, and hasn't been actively developed for a while. openapi-pydantic is a fork of openapi-schema-pydantic that has been updated with support for both Pydantic 1 and 2, and seems to be more actively maintained.

I might be jumping the gun here, so if this is not the way that you've planned to tackle Pydantic2 support, feel free to close this PR.

yanyongyu commented 1 year ago

LGTM. We should change to campatible parser before we can bump pydantic to v2.