search

yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
MIT License
159 stars 21 forks source link

Bug: App auth path matching not work for Enterprise #52

Closed yanyongyu closed 9 months ago

yanyongyu commented 9 months ago 
          This change breaks github enterprise, because urls begin with /api/v3, this regex no longer matches for the /app endpoint

Originally posted by @brainiac in https://github.com/yanyongyu/githubkit/issues/42#issuecomment-1760678551

yanyongyu commented 9 months ago

octokit matches the path by replacing the base url first:

https://github.com/octokit/auth-app.js/blob/c0068e06081a5d930799285a7c79c9c948b676b6/src/hook.ts#L43