search

yanyongyu / githubkit

The modern, all-batteries-included GitHub SDK for Python, including rest api, graphql, webhooks, like octokit!
MIT License
158 stars 21 forks source link

Fix: `PullRequestSimplePropHead` label field can be `null` #65

Closed schelv closed 6 months ago

schelv commented 6 months ago

A similar bug was fixed by: https://github.com/yanyongyu/githubkit/commit/67d4bf55278d65308f57d98044848ff5c4a6c032 So I did the same things and it now works locally.

Fixes #64

yanyongyu commented 6 months ago

Could you please update the patch to make both label and user to be nullable? (as described in #56 )

schelv commented 6 months ago

@yanyongyu

I did not see this warning at the beginning of githubkit/rest/types.py and githubkit/rest/models.py:

"""DO NOT EDIT THIS FILE!

This file is automatically @generated by githubkit using the follow command:

    python -m codegen && isort . && black .

See https://github.com/github/rest-api-description for more information.
"""

And that's exactly what I did 😁 Looking a second time at pyproject.toml I think my proposed change is wrong.

I now want to do it the proper way and am trying to do the python -m codegen && isort . && black . locally.

As a sanity check I'm running the commands in the master branch. However I have to remove the following from pyproject.toml to get codegen to work.

"/components/schemas/copilot-seat-details/properties/assignee" = { enum = "<unset>", oneOf = [
  { "$ref" = "#/components/schemas/simple-user" },
  { "$ref" = "#/components/schemas/team" },
  { "$ref" = "#/components/schemas/organization" },
] }

After running isort . and black . 11 files are changed. Do you know if this is supposed to happen?

yanyongyu commented 6 months ago

The error is caused by schema update made by GitHub as described in #68 . just comment it and mark as [FIXED]