Closed schelv closed 6 months ago
Attention: 24 lines
in your changes are missing coverage. Please review.
Comparison is base (
8a381cb
) 75.60% compared to head (3b8ee2a
) 35.22%. Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
githubkit/core.py | 28.57% | 20 Missing :warning: |
githubkit/exception.py | 71.42% | 2 Missing :warning: |
githubkit/graphql/__init__.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some references may be helpful, take a note here:
@schelv i have made some changes to make the handle clearly. Could you please re-check this to ensure the handle is corrent? Thanks a lot.
It seems the graphql rate limit is not handled.
It seems the graphql rate limit is not handled.
They give a HTTP 200 status code when you exceed that limit 🤦♂️ https://docs.github.com/en/graphql/overview/rate-limits-and-node-limits-for-the-graphql-api#exceeding-the-rate-limit
Maybe this? 😄
if response.is_error:
# check for errors.
....
else:
# also check for errors.
...
For graphql, according to the octokit throttling plugin, an error with RATE_LIMITED
type will be returned when primary rate limit exceeded. i'm not sure if this will cover all cases (secondary rate limit). this may be improved in the feature.
Looks good! What to do with the checks that are failing?
Don't worry about the reduced coverage, this is an imperfect test and is only used to ensure that it can run.
I've added a
RateLimitExceededError
class. This exception provides the time you have to wait before retrying, which simplifies implementing rate limiting.