search

yao-pkg / pkg-binaries

Collection of pkg nodejs binaries that are not supported by pkg
MIT License
89 stars 23 forks source link

check whether self-hosted action runner is still necessary when utilising multiple cores #11

Closed n1ru4l closed 4 years ago

n1ru4l commented 4 years ago

https://github.com/robertsLando/pkg-binaries/pull/9 introduced using all the cores available for compiling. It might be possible that that is sufficient for compiling below 6 hours which would make it runnable n GitHub action runners.

Specs: https://docs.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners#supported-runners-and-hardware-resources Limitations: https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#:~:text=Usage%20limits,-There%20are%20some&text=Job%20execution%20time%20%2D%20Each%20job,apply%20to%20self%2Dhosted%20runners.

robertsLando commented 4 years ago

+1

n1ru4l commented 4 years ago

I started a GitHub hosted action run here: https://github.com/dungeon-revealer/pkg-binaries/runs/1012633978?check_suite_focus=true

robertsLando commented 4 years ago

:eyes:

n1ru4l commented 4 years ago

Good news: build took 5:25 hours. Bad news: forgot to install rename as a dependency 😂 again. So it seems it will work out :)

n1ru4l commented 4 years ago

I also read that you should always use 1.5x of the amount of processes some will be waiting anyways. I will try 3 instead of 2 tomorrow. Maybe that could further reduce the build time :)

n1ru4l commented 4 years ago

https://github.com/dungeon-revealer/pkg-binaries/actions/runs/219595408

4:34 🥰 I will send a pr tomorrow for adding it here, seems like your work machine can be relieved 😀

robertsLando commented 4 years ago

Perfect! This means we can instance multiple builds for time 😍

Daniel

On 22 Aug 2020, at 21:08, Laurin Quast notifications@github.com wrote:

 https://github.com/dungeon-revealer/pkg-binaries/actions/runs/219595408

4:34 🥰 I will send a pr tomorrow for adding it here, seems like your work machine can be relieved 😀

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando commented 4 years ago

@n1ru4l Let me know about the PR, the build in my self hosted machine tooks 6h 0' 10'', I think that with latest fixes and with github runners it will for sure stay under the 6h limits

n1ru4l commented 4 years ago

Yes, I will hopefully have some to do it this evening! I was busy yesterday.