search

yao-pkg / pkg-binaries

Collection of pkg nodejs binaries that are not supported by pkg
MIT License
89 stars 23 forks source link

feat: upload binary using node major tag #16

Closed robertsLando closed 3 years ago

n1ru4l commented 3 years ago

@robertsLando I don't think that this PR should close https://github.com/robertsLando/pkg-binaries/issues/10

robertsLando commented 3 years ago

@n1ru4l Partially as we also spoke about this but I have removed the link. Anyway I don't know how we could make that support, I mean build for macos and win, we would need node docker base images that I don't know if they exists. Alpine and linux are already supported

robertsLando commented 3 years ago

Let's see how this goes: https://github.com/robertsLando/pkg-binaries/runs/1122291781?check_suite_focus=true

n1ru4l commented 3 years ago

Partially as we also spoke about this but I have removed the link. Anyway I don't know how we could make that support, I mean build for macos and win, we would need node docker base images that I don't know if they exists.

You can build the binaries on "raw" action workers outside docker see https://github.com/dungeon-revealer/dungeon-revealer/blob/b9e2a13a4d3c86c2a53d7aa4e027d20ef95186a8/.github/workflows/build-binaries.yml#L10-L51 as a reference. Anyways lets continue discussion in the issue :)

robertsLando commented 3 years ago

the run has fail, could you chek it? @n1ru4l

n1ru4l commented 3 years ago

See https://github.com/n1ru4l/pkg-fetch/commit/bcf418c66bb1419c380f203cb34d49905e66c5ef