search

yao-pkg / pkg-binaries

Collection of pkg nodejs binaries that are not supported by pkg
MIT License
89 stars 23 forks source link

binaries for node 12.18.4 #17

Closed n1ru4l closed 3 years ago

n1ru4l commented 3 years ago

https://nodejs.org/en/blog/vulnerability/september-2020-security-releases/

I am currently creating a patch

n1ru4l commented 3 years ago

It seems like the patch for 12.18.3 can also be used for 12.8.4.

robertsLando commented 3 years ago

Nice!

robertsLando commented 3 years ago

Seems the build is working: https://github.com/robertsLando/pkg-binaries/releases/tag/node12

:tada:

n1ru4l commented 3 years ago

Cool! It would be nice to also have some kind of smoke test CI script that packages and executes the binary, just to makes sure it actually works.

robertsLando commented 3 years ago

Humm that's a really nice idea! I will take a look at it later, if you want to submit a pr in the meanwhile feel free to do it :)

n1ru4l commented 3 years ago

I did just push https://github.com/n1ru4l/pkg-fetch/commit/2a86c241189f52d4e9cdab36daf5d94c2fde210d

n1ru4l commented 3 years ago

What is your opinion on somehow integrating the pkg-fetch fork inside this repository? That way we have one source and don't have to update two repositories.

robertsLando commented 3 years ago

What is your opinion on somehow integrating the pkg-fetch fork inside this repository? That way we have one source and don't have to update two repositories.

@n1ru4l I'm +1 for this! We could use submodules or git-subrepo

robertsLando commented 3 years ago

I'm thinking that as we are using out own fork, we could also make it automatically look for binaries also on this repo and automatically download them :)

The source code is here:

https://github.com/n1ru4l/pkg-fetch/blob/master/lib/index.js#L66 https://github.com/n1ru4l/pkg-fetch/blob/master/lib/cloud.js#L55

https://github.com/n1ru4l/pkg-fetch/blob/master/lib/github.js#L143 https://github.com/n1ru4l/pkg-fetch/blob/master/lib/github.js#L22

We could add our custom download method in github.js as last fallback in cloud.js download function.

Opinions?

n1ru4l commented 3 years ago

yes, let's create a new issue for this! :)