search

yao-pkg / pkg-binaries

Collection of pkg nodejs binaries that are not supported by pkg
MIT License
89 stars 23 forks source link

Node.js v12.18.1 on armv6, armv7 and armv8 #7

Closed n1ru4l closed 4 years ago

n1ru4l commented 4 years ago

Would it be possible to also build binaries for Node.js v12.18.1 for armv6, armv7, and armv8?

robertsLando commented 4 years ago

They are there. Remember that armv6 can also be used in armv7 and armv8 is equal to arm64

Daniel

On 7 Jul 2020, at 13:25, Laurin Quast notifications@github.com wrote:

 Would it be possible to also build binaries for Node.js v12.18.1 for armv6, armv7, and armv8?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

n1ru4l commented 4 years ago

@robertsLando Thanks for the clarification and also for the binaries 👍

robertsLando commented 4 years ago

@n1ru4l You welcome :)

n1ru4l commented 4 years ago

@robertsLando So we are finally trying to upgrade to Node12 now and we run into a few complications.

We are using docker buildx for creating armv7 binaries (since armv6 is not available as a docker image) and not supported by debian and dropped by Node.js).

This means without a fetched-v12.18.1-linux-armv7 we are unable to build those.

Could you please consider providing binaries for armv7?

Edit: It seems building armv7 is currently broken for pkg (at least in docker buildx), as the architecture cannot be resolved reliably. This PR should fix that: https://github.com/vercel/pkg-fetch/pull/101/files

robertsLando commented 4 years ago

Your edit is the answer to your question :) Once that is sorted I will update the build script, actually if you chech how I build now you will see I select armv6 even for armv7 build on purpose to fix that

n1ru4l commented 4 years ago

@robertsLando Yeah I actually figured that out already 😅 So that means it should actually work today if I would place fetched-v12.18.1-linux-armv6 as fetched-v12.18.1-linux-armv7 in the cache, is that correct?

robertsLando commented 4 years ago

@n1ru4l Unfortunally I rarely see a PR to be merged or at least considered with both pkg or pgk-fetch, if you don't see any response I could consider to use your branch to build pkg

robertsLando commented 4 years ago

So that means it should actually work today if I would place fetched-v12.18.1-linux-armv6 as fetched-v12.18.1-linux-armv7 in the cache, is that correct

That is what I'm doing in last year and I didn't have any problem. Using armv6 binaries in armv7 seems safe, just rename it and it works :) As I said in my first comment here: https://github.com/robertsLando/pkg-binaries/issues/7#issuecomment-654792485

n1ru4l commented 4 years ago

Yeah I misunderstood that comment then 🤣. check https://github.com/robertsLando/pkg-binaries/pull/9

n1ru4l commented 4 years ago

closed by https://github.com/robertsLando/pkg-binaries/pull/9