search

yao-pkg / pkg-binaries

Collection of pkg nodejs binaries that are not supported by pkg
MIT License
89 stars 23 forks source link

fix: use fork that correctly detects armv7 #9

Closed n1ru4l closed 4 years ago

robertsLando commented 4 years ago

@n1ru4l Did you tried to build using more cores? What's the result? Is the build time halved at least?

n1ru4l commented 4 years ago

@robertsLando Currently running with 2cores: https://github.com/dungeon-revealer/pkg-binaries/runs/1011216052?check_suite_focus=true

robertsLando commented 4 years ago

@n1ru4l Let me know if performances are improved :) When you are done here I will merge this

robertsLando commented 4 years ago

@n1ru4l Could you also add the cores patch change in build?

n1ru4l commented 4 years ago

compilation time was halved :D

robertsLando commented 4 years ago

@n1ru4l Nice! What do you think about using nproc to get num of cpu and pass that number to the build param? Could you add the changes you made to this pr to use also this feature please?

Also I can make you a collaborator of this repo so instead have two separate repos we keep all binaries in this one. I can edit the docker build file to allow also to you to trigger new builds

n1ru4l commented 4 years ago

@robertsLando would you also be okay with setting up builds for normal osx,linux and windows binaries over here (Those could most likely be done without a custom runner as it dies not take that long)?

robertsLando commented 4 years ago

would you also be okay with setting up builds for normal osx,linux and windows binaries over here

@n1ru4l Sure, create another pr for that maybe so we split things :)

n1ru4l commented 4 years ago

@robertsLando check https://github.com/robertsLando/pkg-binaries/pull/9/commits/2900036dbe6e3be2d448cf46afa00da4b0695446

robertsLando commented 4 years ago

@n1ru4l Perfect! Can we merge and start building some binary?

n1ru4l commented 4 years ago

@robertsLando Lets try!

robertsLando commented 4 years ago

https://github.com/robertsLando/pkg-binaries/runs/1012488972 Let's see what happens @n1ru4l :eyes:

n1ru4l commented 4 years ago

how many cores does the host have? :P

robertsLando commented 4 years ago

Not a super pc, 4 cores :laughing: