`slides` property needs array type definition - Githubissues

yaodingyd / react-flickity-component

A React.js component for using @desandro's Flickity

314 stars 51 forks source link

`slides` property needs array type definition #112

Closed lstellway closed 3 years ago

lstellway commented 4 years ago

Description

Please excuse me if I have it wrong, but I believe the slides property should have an array ([]) type definition.

Setup

react-flickity-component:3.5.0
flickity:2.2.1
typescript

Testing

Create a carousel and set the ref

<Flickity flickityRef={(ref) => setCarousel(ref)} {...options} />

In a callback or hook method, log the Flickity reference object:
```
const setCarousel = (carousel) => {
console.log(carousel);
};
```

Expected Result Console will log an object with a slides property that is an array.

This should be a quick fix - once confirmed, I would be happy to create a pull request.

theolampert commented 3 years ago

@loganstellway This looks reasonable, feel free to open a PR