Using React 16 and Portals with Flickity

yaodingyd / react-flickity-component

A React.js component for using @desandro's Flickity

314 stars 51 forks source link

Using React 16 and Portals with Flickity #16

Closed ryanwiemer closed 6 years ago

ryanwiemer commented 6 years ago

@theolampert

I can't say I have tested this myself but have you taken a look at this comment on the flickity repo regarding React 16 and portals?

https://github.com/metafizzy/flickity/pull/488#issuecomment-339361054

I'm just curious if that is relevant to your code here or if the approach that you have taken has pros/cons that make it a better choice.

Thanks, Ryan

theolampert commented 6 years ago

Hey @ryanwiemer I have seen this and as of React 16 this would definitely be the way to go. I just haven't had a heap of time to look into this recently but imagine following the example codepen here would be an excellent starting point for a proof of concept: https://codepen.io/smartmike/pen/dZBNVv. Would you or anyone else be willing to submit a WIP PR?

yaodingyd commented 6 years ago

@theolampert This can be closed now.