search

yaodingyd / react-flickity-component

A React.js component for using @desandro's Flickity
314 stars 51 forks source link

Add declaration file for typescript types #54

Closed justinemmanuelmercado closed 5 years ago

justinemmanuelmercado commented 5 years ago

https://github.com/theolampert/react-flickity-component/issues/52

justinemmanuelmercado commented 5 years ago

No problem, thank you for your work! 👍

justinemmanuelmercado commented 5 years ago

Hey @theolampert, maybe we could hold off on releasing this for now, I think I should submit a PR to DefinitelyTyped first just to get the FlickityOptions interface exported instead of hard coding the interface here. I'll update this when my PR there gets merged.

theolampert commented 5 years ago

@justinemmanuelmercado sounds good, no rush on releasing.

timdev commented 5 years ago

Chiming in here, as I work with @justinemmanuelmercado.

The issue we ran into in our discussion is that if we submit a PR to DefinitelyTyped to expose FlickityOptions (instead of duplicating the interface here, as this PR does currently), we'll need to add a dependency on @types/flickity to this project.

I'm not expecting any strong objection, but wanted to ping @theolampert for thoughts before we proceed.

theolampert commented 5 years ago

@timdev Hey!, I'm not against adding the typings as a dependency, particularly if it means less maintenance for this package going forward, simply bumping the typings when I pump the flickity dependency would make it easier for me.