search

yaodingyd / react-flickity-component

A React.js component for using @desandro's Flickity
314 stars 51 forks source link

This doesn't look right. Besides we already have the check in `componentDidMount` lifecycle. #72

Closed ebrahimiaval closed 5 years ago

ebrahimiaval commented 5 years ago

This doesn't look right. Besides we already have the check in componentDidMount lifecycle.

Originally posted by @yaodingyd in https://github.com/theolampert/react-flickity-component/pull/71#issuecomment-508969085

NO, This is right. in SSR componentDidMount do not effect JUST 'constructor' and 'render' work.

you must ignore import window dependency plugins to fix 'window undefined' error. in this commit i ignored flickity to fix it. now we can use in both side.

yaodingyd commented 5 years ago

You can comment on the original PR.