search

yaodingyd / react-flickity-component

A React.js component for using @desandro's Flickity
314 stars 51 forks source link

Updated declare class with relevant functions in typescript types declaration #76

Closed shabith closed 5 years ago

shabith commented 5 years ago

I have added the most of the missing functions to the typescript definition file.

theolampert commented 5 years ago

@shabith thank you very much for your work here.

I have added the most of the missing functions to the typescript definition file.

Does this mean there are still some functions missing?

shabith commented 5 years ago

Does this mean there are still some functions missing?

Hi @theolampert, I didn't add the fullscreen related functions as it is related to another plugin. However after checking it again, I feel there is no harm adding that as well :) Shall I add those and resubmit a PR?

theolampert commented 5 years ago

@shabith yes that would probably be the easiest for the end user, I can add a note about plugins to the readme. Thanks!

shabith commented 5 years ago

Hi @theolampert I have added the missing fullScreen plugin related functions.

theolampert commented 5 years ago

@shabith thanks alot this seems to work well for me. I have to head off but I'll merge this now and release a bit later on.