Duplicate Employee ID

[yaojiax]

After manually editing the raw data file to include an extra valid entry, adding a new entry creates a duplicate employee with the same employee ID. This may make it very cumbersome to search for the specific employee.

To replicate: add a valid entry into the json file manually add n/test p/98765432 d/Marketing pr/1000 15 e/johnd@example.com a/John street, block 123, #01-01

[nus-se-script]

Team's Response

Thanks for raising this up. Users who want to directly add more employees to the raw data file also need to increase the "maxID" value, so that future employees are correctly assigned valid ID numbers. Since the UG has already acknowledged that incorrectly editing the data file may lead to errors, we have decided to reject this bug report.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: The UG mentions that incorrectly editing the data file will "discard all data and start with an empty data file at the next run." As my data was not discarded and that all my data has been kept, I think I can fairly assume that my data file has been edited properly to a valid format. Thus, it is possibly confusing for advanced users to see that there are such errors if the data file has been assumed to be correctly edited, and there are no mentions of this at all in the UG or DG. Thus, I think I can assume that it is a valid bug that is not accounted for.

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---