yaojiax / pe

0 stars 0 forks source link

Leave does not take into account 366 days #2

Open yaojiax opened 1 year ago

yaojiax commented 1 year ago

Suppose the year is 2024, a leap year, and an employee is taking leave for the whole year. I cannot easily assign 366 days of leave to him.

image.png

nus-pe-script commented 1 year ago

Team's Response

Leave is meant to record and keep track of the employee's allotted annual leave, not long terms leaves like e.g. maternity leave. An employee is not going to be given 366 days of annual leave per year, so this is unlikely to be an issue.

Marked as Low this might only have in the rarest of circumstances.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If we discuss the in the context of "employee's allotted annual leave", I suppose in some jobs it is possible to take the full year off for medical reasons. Furthermore, this is merely an extension of what the team already proposed - that there can be leaves from 0 to 365 days. Unless setting leaves at 365 days is also a design flaw, then I suppose that 366 days is just an edge case of where 365 days is possible in the leap years.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]