search

yaojiax / pe

0 stars 0 forks source link

Loss of all user data when a duplicate entry is added #4

Open yaojiax opened 1 year ago

yaojiax commented 1 year ago

image.png

Adding a duplicate entry directly into the data file causes causes the app to start up with an empty list.

image.png

soc-pe-bot commented 1 year ago

Team's Response

Stated in the UG not to touch the data file, hence the response is rejected, thank you.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

First of all, it's not stated in the UG to touch the data file, but rather, it is 'discouraged'. If it did say outright to not touch the data file, then I agree this won't be valid, but it only discourages it.

image.png

Secondly, I would argue that the addition of a "duplicate" data is valid. For one, it is mentioned that if I change the data file to make its format invalid, it will discard all data. It could be that it is slightly unclear what this "format" means as a duplicate entry should be intuitively a properly formatted data as the structure of the information is the same, as evident from this definition (Computing definition)

image.png

I would argue that the User Guide should outright tell users not to modify the data file as is practiced by modern software, or to at least inform the user that a duplicate entry constitutes an invalid entry as they did in their batchadd command. After all, its indeterminate what constitutes an "advanced" user if the instructions to help them in this command is so unclear and results in such disastrous consequences.