yaojiax / pe

0 stars 0 forks source link

Able to set Date of Birth before Date of Joining #7

Open yaojiax opened 1 year ago

yaojiax commented 1 year ago

image.png

It doesn't make sense that an employee is born before he joins, there should be input validation here as Date of Joining should be set after Date of Birth.

soc-pe-bot commented 1 year ago

Team's Response

Indeed a flaw, should have an error message stating that is not possible, however severity should be low since it is unlikely that the user will set the same date of birth to be after date of joining. Not a priority to do in the current implementation so marked as "not in scope".

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image_2023-04-18_12-21-17.png

According to the guidelines, while it is indeed true that rectifying it is less important, there are (1) no mentions in the UG that this is not supported/is a feature that is coming soon and (2) the software does not fail gracefully and just takes in the input, instead of even providing an error message.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]