Closed fieldju closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
packages/measured-reporting/lib/registries/DimensionAwareMetricsRegistry.js | 15 | 16 | 93.75% | ||
packages/measured-signalfx-reporter/lib/validators/inputValidators.js | 4 | 5 | 80.0% | ||
packages/measured-reporting/lib/reporters/Reporter.js | 38 | 39 | 97.44% | ||
packages/measured-reporting/lib/registries/SelfReportingMetricsRegistry.js | 58 | 63 | 92.06% | ||
packages/measured-signalfx-reporter/lib/reporters/SignalFxMetricsReporter.js | 50 | 57 | 87.72% | ||
<!-- | Total: | 247 | 262 | 94.27% | --> |
Totals | |
---|---|
Change from base Build 117: | 3.3% |
Covered Lines: | 607 |
Relevant Lines: | 679 |
Dashboard from user acceptance test server, nothing special but shows mertics with dimensions flowing through.
You can filter and or group by dimensions such as request path
I wasn't super thorough but overall it is looking pretty good to me. Nice work.
The new package descriptions can be found here, at the new doc site: https://yaorg.github.io/node-measured/
to see the new packages in action checkout the end to end tutorial here:
https://yaorg.github.io/node-measured/tutorial-SignalFx%20Express%20Full%20End%20to%20End%20Example.html
I still have more tests to add and a couple TODO's to take care of, but I wanted to get this open now.