search

yaorg / node-measured

A Node metrics library for measuring and reporting application-level metrics, inspired by Coda Hale, Yammer Inc's Dropwizard Metrics Libraries
https://yaorg.github.io/node-measured/
MIT License
517 stars 52 forks source link

Do not use Object.values(...) #52

Closed Qard closed 5 years ago

Qard commented 5 years ago

The Object.values(...) function was not added until Node.js 7.x. Use Object.keys(...).map(...) until the Node.js 6.x LTS expires.

Fixes #51

Qard commented 5 years ago

The failure is unrelated.

I opened another PR to test all active release lines, and it seems the test suite currently only passes on Node.js 8, which is no longer the latest LTS: https://github.com/yaorg/node-measured/pull/53

Qard commented 5 years ago

Closing in favor of #54.