yaorg / node-measured

A Node metrics library for measuring and reporting application-level metrics, inspired by Coda Hale, Yammer Inc's Dropwizard Metrics Libraries
https://yaorg.github.io/node-measured/
MIT License
517 stars 52 forks source link

Support all active Node.js release lines #54

Closed Qard closed 5 years ago

Qard commented 5 years ago

The Object.values(...) function was not added until Node.js 7.x. Use Object.keys(...).map(...) until the Node.js 6.x LTS expires.

Node.js 10.x+ also deprecated the use of a string matcher for the assert.throws(...) function, now throwing ERR_AMBIGUOUS_ARGUMENT.

All active release lines have been added to the .travis.yml to ensure complete test coverage.

Fixes #51

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 225


Totals Coverage Status
Change from base Build 222: 0.0%
Covered Lines: 741
Relevant Lines: 819

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 225


Totals Coverage Status
Change from base Build 222: 0.0%
Covered Lines: 741
Relevant Lines: 819

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 227


Totals Coverage Status
Change from base Build 222: 0.0%
Covered Lines: 741
Relevant Lines: 819

💛 - Coveralls
fieldju commented 5 years ago

LGTM

Qard commented 5 years ago

Thanks for the quick response! 🎉