search

yaorg / node-measured

A Node metrics library for measuring and reporting application-level metrics, inspired by Coda Hale, Yammer Inc's Dropwizard Metrics Libraries
https://yaorg.github.io/node-measured/
MIT License
517 stars 52 forks source link

Add unrefTimers option to Reporter #55

Closed Qard closed 5 years ago

Qard commented 5 years ago

The use of interval timers in the Reporter class causes the event loop to be held open even if there is no other activity. By using the unrefTimers option, those interval timers will now be unref'd so the event loop can exit when there are no other ref'd handles.

Qard commented 5 years ago

The failure appears to be unrelated--apparently yarn test:node:coverage is not properly generating the coverage directory on Travis CI, for some reason. Not sure why. It works for me locally. 🤷‍♂️

fieldju commented 5 years ago

Yeah, the build configuration is broken, I need to fix it before this gets merged. There are certain tasks that should only run 1 time, when you added the additional node envs it runs everything per node env. I switched travis to use build stages which is a beta feature, but not everything is working properly yet.

Will try to get to it today.

Cheers,

Justin

On Thu, Dec 13, 2018 at 8:43 AM Stephen Belanger notifications@github.com wrote:

The failure appears to be unrelated--apparently yarn test:node:coverage is not properly generating the coverage directory on Travis CI, for some reason. Not sure why. It works for me locally. 🤷‍♂️

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/yaorg/node-measured/pull/55#issuecomment-447037830, or mute the thread https://github.com/notifications/unsubscribe-auth/AArcLi0LF5s0UxPJ3uQsrftwnp-RcIPBks5u4oPGgaJpZM4ZR-hq .

-- Justin Field fieldju@gmail.com LinkedIn https://www.linkedin.com/in/fieldju | @fieldju

Qard commented 5 years ago

Looks probably related to: https://github.com/yarnpkg/yarn/issues/6746