search

yaorg / node-measured

A Node metrics library for measuring and reporting application-level metrics, inspired by Coda Hale, Yammer Inc's Dropwizard Metrics Libraries
https://yaorg.github.io/node-measured/
MIT License
517 stars 52 forks source link

Defer initial report #56

Closed Qard closed 5 years ago

Qard commented 5 years ago

If adding several metrics at once, on the same interval, only the first will be reported in the initial report due to the immediate call to reporter._reportMetricsWithInterval(...). By wrapping that in a setImmediate(...), any other metrics set in that tick should now also be included in the initial report.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 344

Totals Coverage Status
Change from base Build 343: 0.1%
Covered Lines: 749
Relevant Lines: 827
💛 - Coveralls
Qard commented 5 years ago

What do I need to do?

fieldju commented 5 years ago

Just use the GitHub release page to do a release. Copy the format from one of the previous releases. Make sure to bump the minor version in your release.

If this isn't making sense I can get you screen shots after lunch

Cheers,

Justin

On Tue, Dec 18, 2018 at 12:29 PM Stephen Belanger notifications@github.com wrote:

What do I need to do?

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/yaorg/node-measured/pull/56#issuecomment-448359246, or mute the thread https://github.com/notifications/unsubscribe-auth/AArcLpI5iB0IJ93uVnBBxPO1dfvpprdMks5u6VAwgaJpZM4ZY-Lx .

-- Justin Field fieldju@gmail.com LinkedIn https://www.linkedin.com/in/fieldju | @fieldju

Qard commented 5 years ago

Ah, yep, I can do that. The package publish itself all happens automatically though, when the PR lands in master, right?

fieldju commented 5 years ago

Yeah

On Tue, Dec 18, 2018 at 12:49 PM Stephen Belanger notifications@github.com wrote:

Ah, yep, I can do that. The package publish itself all happens automatically though, when the PR lands in master, right?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/yaorg/node-measured/pull/56#issuecomment-448365147, or mute the thread https://github.com/notifications/unsubscribe-auth/AArcLgtkf4sXGzwqiK0eNpI26lFuqQBIks5u6VTagaJpZM4ZY-Lx .

-- Justin Field fieldju@gmail.com LinkedIn https://www.linkedin.com/in/fieldju | @fieldju

Qard commented 5 years ago

Should this be minor or patch? Seems more like bug-fix territory to me. 🤔

fieldju commented 5 years ago

I'm ok with either

On Tue, Dec 18, 2018 at 1:02 PM Stephen Belanger notifications@github.com wrote:

Should this be minor or patch? Seems more like bug-fix territory to me. 🤔

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/yaorg/node-measured/pull/56#issuecomment-448369130, or mute the thread https://github.com/notifications/unsubscribe-auth/AArcLpneTWo6TDtNZH-38AhwkErNYAiuks5u6VfbgaJpZM4ZY-Lx .

-- Justin Field fieldju@gmail.com LinkedIn https://www.linkedin.com/in/fieldju | @fieldju

Qard commented 5 years ago

Sorry, not super clear on how all the release automation stuff fits together...

What actually triggers the publish.sh script? It seems to be gated with if: type != pull_request AND tag IS present, which means it happens when a tag is pushed? Does that tag come from the github release being created?

fieldju commented 5 years ago

Yes, tags get created from the GitHub release dashboard.

👇 Below is an example

fieldju commented 5 years ago

image

fieldju commented 5 years ago

BTW the automation integration with Lerna is a little weird, don't be alarmed when travis runs the tag build 2x, it will just release to NPM once.