search

yaorg / node-measured

A Node metrics library for measuring and reporting application-level metrics, inspired by Coda Hale, Yammer Inc's Dropwizard Metrics Libraries
https://yaorg.github.io/node-measured/
MIT License
517 stars 52 forks source link

Switch to console-log-level #62

Closed Qard closed 5 years ago

Qard commented 5 years ago

Bunyan has an optional dependency on dtrace-provider, which is a native module. With optional dependencies, it's fine for them to fail to install. On Windows, however, the build process uses node-gyp and therefore fails the install with a big scary error.

To avoid the build error, I've switched to a simple console logger.

NOTE: I chose to just make a new PR for this to replace the work in #61.

Fixes #61

fieldju commented 5 years ago

Can you utilize the prefix functionality and tack on a timestamp (preferably an ISO 8061 ts) to the log message please. https://github.com/watson/console-log-level/blob/master/index.js#L36

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 363

Totals Coverage Status
Change from base Build 356: 0.02%
Covered Lines: 751
Relevant Lines: 829
💛 - Coveralls
Qard commented 5 years ago

Added a prefix function. What do you think? Is that sufficient, or would you prefer a different prefix?

fieldju commented 5 years ago

Added a prefix function. What do you think? Is that sufficient, or would you prefer a different prefix?

Im pretty sure that should work with Splunk, and will defiantly be useful for dev if manually tailing logs etc.

Qard commented 5 years ago

Force-pushed to appease the linter. 😅

fieldju commented 5 years ago

Ok, I gave my approval, are you going to merge and cut the v1.41.0 release?

Qard commented 5 years ago

Sorry for the lack of response. I'm in Europe right now, so that last commit was after midnight here. I just went to sleep after pushing that. 😅

Thanks for landing it. It'll be great to be rid of the dtrace-provider install failures! 🙀