yaoweibin / nginx_ajp_module

support AJP protocol proxy with Nginx
http://github.com/yaoweibin/nginx_ajp_module
246 stars 60 forks source link

Does not compile with Nginx 1.21.1 #51

Open ip6li opened 3 years ago

ip6li commented 3 years ago

Compiler complains with:

nginx_ajp_module/ngx_http_ajp.c:140:29: Fehler: »ngx_http_request_t« {alias »struct ngx_http_request_s«} hat kein Element namens »space_in_uri«; meinten Sie »plus_in_uri«?
     if (r->quoted_uri || r->space_in_uri || r->internal) {
                             ^~~~~~~~~~~~
                             plus_in_uri
FraPazGal commented 3 years ago

Hello,

Is there any update on this? The compilation is failing with the following error:

ngx_http_ajp.c: In function 'sc_for_req_get_uri':
ngx_http_ajp.c:139:29: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'space_in_uri'; did you mean 'plus_in_uri'?
     if (r->quoted_uri || r->space_in_uri || r->internal) {
                             ^~~~~~~~~~~~
                             plus_in_uri
make[1]: *** [objs/Makefile:2251: objs/addon/nginx-module-ajp-0.20200326.0/ngx_http_ajp.o] Error 1

The error should be related to the changes performed in the latest NGINX version `1.21.1:

https://github.com/nginx/nginx/compare/release-1.21.0...release-1.21.1

ip6li commented 3 years ago

This one is outdated, see https://github.com/dvershinin/nginx_ajp_module

ssticsistemas commented 2 years ago

Hi, same error and my solution with updated project: in file ngx_http_ajp.c, line 139: _if (r->quoted_uri || r->space_in_uri || r->internal) {_ replace with: _if (r->quoted_uri || r->plus_in_uri || r->internal) {_ and rerun ./configure, make and make install working correctly

tao12345666333 commented 2 years ago

Hi, same error and my solution with updated project: in file ngx_http_ajp.c, line 139: _if (r->quoted_uri || r->space_in_uri || r->internal) {_ replace with: _if (r->quoted_uri || r->plus_in_uri || r->internal) {_ and rerun ./configure, make and make install working correctly

In fact this behavior is inconsistent. You can just delete it.

- if (r->quoted_uri || r->space_in_uri || r->internal) {
+ if (r->quoted_uri || r->internal) {

space_in_uri is to handle some bad clients, but it's not necessary now

yaoweibin commented 2 years ago

Can you issue a pull request? Thanks.

Jintao Zhang @.***> 于2022年10月26日周三 05:01写道:

Hi, same error and my solution with updated project: in file ngx_http_ajp.c, line 139: if (r->quoted_uri || r->space_in_uri || r->internal) { replace with: if (r->quoted_uri || r->plus_in_uri || r->internal) { and rerun ./configure, make and make install working correctly

In fact this behavior is inconsistent. You can just delete it.

  • if (r->quoted_uri || r->space_in_uri || r->internal) {+ if (r->quoted_uri || r->internal) {

space_in_uri is to handle some bad clients, but it's not necessary now

— Reply to this email directly, view it on GitHub https://github.com/yaoweibin/nginx_ajp_module/issues/51#issuecomment-1291137957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFRGNLVPOTLD27FN7QJNTWFBDDRANCNFSM5AAF6DPQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tao12345666333 commented 1 year ago

Sure!