search

yaph / d3-geomap

A library for creating geographical maps based on D3.js
https://d3-geomap.github.io/
MIT License
133 stars 45 forks source link

Problem adding labels to choropleth map #57

Closed geraldo closed 5 years ago

geraldo commented 5 years ago

As you stated in issue #17 you won't add support for labels in the core library. I now try to add them with standard d3.js methods, but can't make them appear on the right position. Could you please have a look at this post?

yaph commented 5 years ago

I replied on Stack Overflow. Also here is the bl.ocks page https://bl.ocks.org/yaph/5714d48fee1f1996415f73549e1b15c6

geraldo commented 5 years ago

Thanks for your help. Would you be interested in a pull request with an example based on this bl.ocks to show postUpdate in action?

yaph commented 5 years ago

I am very interested in better documenting d3-geomap. An example for postUpdate is very appreciated. At some point I want to consolidate the content of the examples directory and the example maps on the documentation site. I created this issue hoping to get feedback from people using of this library.

yaph commented 5 years ago

@geraldo if you are still interested in providing your example, I'd appreciate a PR with an accompanying test. I want to use the example maps in examples as test cases and have added 2 tests so far. I created a corresponding issue with some guidance https://github.com/yaph/d3-geomap/issues/60

geraldo commented 5 years ago

@yaph Yes, still interested, but with no time this week. I'll have it on my schedule for next week so.

yaph commented 5 years ago

No need to hurry, just wanted to let you know about the changes I made.