search

yaph / geonamescache

geonamescache - a Python library for quick access to a subset of GeoNames data.
https://pypi.org/project/geonamescache/
MIT License
99 stars 38 forks source link

Fixes #8 and #9, with some other upgrades #10

Closed mlissner closed 9 years ago

mlissner commented 9 years ago

My commit messages should tell the full story, but here are the highlights:

  1. I've updated the requirements.txt file in both the default and develop branches so that it doesn't have extraneous stuff nor missing stuff.
  2. I've added type conversions for the data in cities.py, making the right things ints and floats.
  3. I've updated the fab file to work on new installations and I've documented it's usage.
  4. I've made all the data generating scripts use a context manager, and I set them all to indent=2, making them pretty print (this is better for diffs and for humans).

This PR wound up being a bit bigger than I'd hoped, but the readme and requirements changes were unavoidable. The indent changes might be controversial (hopefully not), but they should make life easier for us.

yaph commented 9 years ago

I just quickly reviewed your changes and will hopefully merge tomorrow. Thanks for all your work!

yaph commented 9 years ago

Thanks again! I merged your changes and created a new pypi release.

mlissner commented 9 years ago

My pleasure. Make the code you wish to see in the world!

yaph commented 9 years ago

That's true!