search

yaph / geonamescache

geonamescache - a Python library for quick access to a subset of GeoNames data.
https://pypi.org/project/geonamescache/
MIT License
99 stars 38 forks source link

Fix importib files is only support 3.9 so revert #33

Closed Bennyelg closed 2 years ago

Bennyelg commented 2 years ago

importlib resources.files is only when python is 3.9 or greater. please approve this PR

Bennyelg commented 2 years ago

@yaph Anychance for review?

yaph commented 2 years ago

Looks good. The line from importlib import resources can be removed and the Python version 3.8 be added in setup.py and .github/workflows/pythonpackage.yml. Do you want to add these changes to your PR?

Bennyelg commented 2 years ago

Sure

On Mon, 1 Aug 2022, 22:45 Ramiro Gómez, @.***> wrote:

Looks good. The line from importlib import resources can be removed and the Python version 3.8 be added in setup.py and .github/workflows/pythonpackage.yml. Do you want to add these changes to your PR?

— Reply to this email directly, view it on GitHub https://github.com/yaph/geonamescache/pull/33#issuecomment-1201639565, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHWPHDHFHRJ4DWCFDOSKDLVXASNVANCNFSM55HXWFDA . You are receiving this because you authored the thread.Message ID: @.***>

Bennyelg commented 2 years ago

@yaph Done.

yaph commented 2 years ago

Thank you!

Bennyelg commented 2 years ago

@yaph can you tag the new version ?

yaph commented 2 years ago

@Bennyelg done.