search

yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Adding the ability to check prototype properties in setUnknownProperty #23

Closed elatonsev closed 8 years ago

elatonsev commented 8 years ago

If object is intended to be only a prototype then just defineProperty rather than delegate

Taken from Ember.ObjectProxy https://github.com/emberjs/ember.js/blob/v2.4.0/packages/ember-runtime/lib/mixins/-proxy.js#L86

It could be useful when you creating objects with container

let buffer = BufferedProxy.create(
    getOwner(this).ownerInjection(),
    {content: content}
);

Fix for issue https://github.com/yapplabs/ember-buffered-proxy/issues/22

GreatWizard commented 8 years ago

I also work with ember-cp-validations, this fix is pretty handy!

elatonsev commented 8 years ago

@GreatWizard uploaded it as package until PR is not merged. https://www.npmjs.com/package/ember-buffered-proxy-modified

blimmer commented 8 years ago

@elatonsev I just merged #25 which is this fix + a test. Thank you for contributing this fix!!