yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Shorten method names? #4

Closed mitchlloyd closed 9 years ago

mitchlloyd commented 9 years ago

I feel like I'm typing "buffered" a lot and it feels redundant. Would the maintainers be open to shortening the method names?

From this:

buffer.discardBufferedChanges()
buffer.applyBufferedChanges();
buffer.get('hasBufferedChanges');

To this:

buffer.discardChanges()
buffer.applyChanges();
buffer.get('hasChanges');
stefanpenner commented 9 years ago

I would be open to short aliases while leaving the original verbose ones around for compatibility.

mitchlloyd commented 9 years ago

@stefanpenner see https://github.com/yapplabs/ember-buffered-proxy/pull/5