search

yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Add additional check for meta.isInitializing #41

Closed enspandi closed 5 years ago

enspandi commented 5 years ago

The check for m.proto === this in setUnknownProperty was introduced to allow defining additional values at create time, especially in the case of using the ember-cp-validations addon.

This code, taken from the the Ember.ProxyMixin, has changed due to a refactor since 3.6, see: https://github.com/emberjs/ember.js/commit/a80eba3d9876542e35837897042fe02b9f6f3f09#diff-9bf8bbd79c58f7c1479813cd250667ddL93

My issue was in combination with Ember 3.8 and ember-cp-validations having buffer changes just after creation. This PR simply adds another check for the new method meta.isInitializing() to skip buffer changes during initialization to be compatible with Ember 3.6+.

enspandi commented 5 years ago

@lukemelia Travis seems to be failing with Yarn was installed, but doesn't seem to be working. Is there something wrong in the general travis setup in this addon ?

enspandi commented 5 years ago

Maybe @blimmer can help me out here? BufferedProxy does not seem to be working correctly since 3.6...

lukemelia commented 5 years ago

@enspandi I suspect that the node version being run needs to be updated.

lukemelia commented 5 years ago

Closing in favor of #46