yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Fix an issue with notifying about changes in Ember 3.13 and upgrade the addon #49

Closed tniezurawski closed 4 years ago

tniezurawski commented 4 years ago

Fixes: https://github.com/yapplabs/ember-buffered-proxy/issues/48


I know PR is huge. In fact, the change that fixes the issue with notifying about changes is a one-liner. But I really wanted to refresh the addon as this is something we use in our project a lot.

I added acceptance tests to this project because I think it relies a lot on Ember internals. It's cool that you have unit tests but it's not enough because the whole Ember is just a black box there. We need to be sure that changes are propagated on views when we change buffered properties and when we apply the changes to the content.

It's probably easier to review this change commit by commit but here are the milestones:

lukemelia commented 4 years ago

Nice work, @tniezurawski! I sent you a collaborator invite. Welcome to the team. :-)

tniezurawski commented 4 years ago

Thanks @lukemelia! :)