search

yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Remove `ember-notify-property-change-polyfill` #82

Closed charlesfries closed 2 years ago

charlesfries commented 2 years ago

Fixes this deprecation warning in host apps:

Prior to v7.26.6, ember-cli-babel sometimes transpiled imports into the equivalent Ember Global API, potentially triggering this deprecation message indirectly, even when you did not observe these deprecated usages in your code.

The following outdated versions are found in your project:

* ember-cli-babel@6.18.0, currently used by:
  * ember-notify-property-change-polyfill@0.0.1 (Dormant)
    * Depends on ember-cli-babel@^6.6.0
    * Added by ember-buffered-proxy@2.0.0

a7aa0c0da4c14cb4162675522249cb2ab0b6de91 is the commit that added this lib.

I know I've imported notifyPropertyChange before w/o this polyfill since it's included in Ember, but are there consequences to removing this that I am unaware of?

charlesfries commented 2 years ago

@lukemelia any thoughts/anything I can do to help get a fix merged in? This is the last crucial addon I need updated before shifting to Ember v4 😅 Ty!