search

yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Conditionally choose notifyPropertyChange context based on Ember version #86

Closed fsmanuel closed 2 years ago

fsmanuel commented 2 years ago

I cherry picked the changes from @achambers in #68 and updated ember-compatibility-helpers to ^1.2.6.

fsmanuel commented 2 years ago

@lukemelia can you approve the workflow?

fsmanuel commented 2 years ago

CI failed: https://github.com/yapplabs/ember-buffered-proxy/actions/runs/2300356699 I tried to update ember-auto-import but couldn't get it to work (hence the two new workflow requests). Hope I find some time to figure out how to make the tests run.

fsmanuel commented 2 years ago

@lukemelia I opened https://github.com/yapplabs/ember-buffered-proxy/pull/87 to make it easier to debug the failing tests.

lukemelia commented 2 years ago

Superseded by #87

fsmanuel commented 2 years ago

@lukemelia we still need this PR to fix the problem ;-)

fsmanuel commented 2 years ago

I'll open a new PR with master rebased.

lukemelia commented 2 years ago

lol. whoops