search

yapplabs / ember-buffered-proxy

An Ember Proxy the enables change buffering
MIT License
166 stars 31 forks source link

Remove ember-notify-property-change-polyfill #93

Closed fsmanuel closed 2 years ago

fsmanuel commented 2 years ago

The readme states that version > 1.0.1 requires ember >= 3.8 and the polyfill is only used for emberVersion.lt('3.1.0'): https://github.com/rondale-sc/ember-notify-property-change-polyfill/blob/master/index.js#L13

So I think it's save to remove the dependency. That also removes this deprecation:

Bildschirmfoto 2022-05-11 um 13 13 50
fsmanuel commented 2 years ago

@lukemelia Our tests fail for ember 3.8 because we use @action decorators: https://github.com/yapplabs/ember-buffered-proxy/runs/6387142409?check_suite_focus=true

For ember 3.12 one test is failing because tracked properties were introduced in 3.13: https://github.com/yapplabs/ember-buffered-proxy/runs/6387142489?check_suite_focus=true

I think everything should work for 3.12 if you use @computed decorators but the effort to cover it in the tests is to much. So I updated the readme to reflect the compatibility.

lukemelia commented 2 years ago

Released as 2.1.1