search

yapplabs / ember-cli-bourbon

Include bourbon in an ember-cli app.
MIT License
54 stars 15 forks source link

How could I update to bourbon 5x? #20

Closed jaltfeld closed 7 years ago

jaltfeld commented 7 years ago

I installed as directed and everything worked great - but after using a somewhat less convenient method of getting neat on my project I then found a similar way of getting bitters on and once I got that in place I ended up discovering that bitters wont work w/o a 5x version of bourbon ... so I manually updated the bower bourbon package only to get a broccoli error (I'm guessing relating to ember-cli-bourbon?) - sorry for not being specific here - but something along the lines of "filepath being watched unavailable or doesnt exist" ... well it turns out that the .scss files in the new 5x bourbon package are at the end of a slightly different filepath - which I now assume is why I got that error - so I'm wondering if you had any insight on how to change ember-cli-bourbon to be looking in the NEW(er) path?

jaltfeld commented 7 years ago

Just to follow up - in case anyone else may be in a similar situation... I was able to sort of "hack up" a 5x bourbon for my bitters to run. I ended up using just the bower version of bourbon, and configuring it's path in the sassOptions/includePaths for ember-cli-sass (like I did with an npm package called bourbon-neat - to clarify what I wrote above ... also to further clarify that a twitter post by Chase McCarthy explained a clever way to pull in bitters through your package.json file, without there being a bona fide "package" for it)...

But back to the point - it dawned on me that since it was the pathing that seemed to be causing the problem (see previous comment) I could just download the source for the new version and copy it's sass assets into the folder (at the end of the path thats already set to be made available to ember-cli-sass - in the 4.2.6 installation) and copy the sass "@import" statements from the v5.0.0-beta.8 _bourbon.scss and paste them in at the end of the _bourbon.scss in the 4.2.6 installation (again, with the asset folder).

So ...even though I reverted back to not using ember-cli-bourbon, I think that this solution (of adding in the 5 assets/@imports to the active 4 installation), will still work until Yapplabs updates their repo to depend on the newer version of bourbon.

It's a little bit inconvenient as far as just running "npm install" or (in this case) "bower install" on a fresh pull from your repo and in that sense ... it's kind of ugly - but if It seems to make things work for (in the immediate present) and if you can remember you did it, it might be marginally maintainable with a little extra effort.