search

yapplabs / ember-key-responder

cocoa inspired approach to keyboard event handling in ember
MIT License
51 stars 11 forks source link

Don't use Ember.View (breaks Ember 2.x apps) #28

Open SaladFork opened 8 years ago

SaladFork commented 8 years ago

Installing this addon in a 2.x Ember application causes an error:

Uncaught TypeError: Cannot read property 'extend' of undefined

I suspect from the stack trace this is due to the addon trying to create a view. This code is triggered by the instance initializer trying to look up this view.

Installing ember-legacy-views fixes the issue, since it defines Ember.View. This should either not be required (preferred), or installing ember-key-responder should automatically install ember-legacy-view as well.

billdami commented 8 years ago

:+1: This addon currently breaks my app upon installation when using Ember 2.2.0

SaladFork commented 8 years ago

This is now particularly annoying as Ember / Ember CLI 2.4 (released today) throw a deprecation warning about ember-legacy-views being included in the app.

lukemelia commented 8 years ago

Hey all, we are strongly considering deprecating this addon in favor of ember-keyboard. Feedback on this is welcome.