search

yapplabs / ember-wormhole

Render a child view somewhere else in the DOM.
MIT License
284 stars 68 forks source link

Fix #104 Toggling renderInPlace #107

Closed dnachev closed 5 years ago

dnachev commented 6 years ago

After the change in #101, the wormhole cannot toggle from render in place to render elsewhere, because destinationElement CP is never read and therefore the observer will never fire when renderInPlace has changed. (Issue #104).

I'm little unclear why we need the change from #101, but presumably we want to specify an explicit element to be used as a wormhole rather than selector. In this case, we will need to a new computed property (private) to capture all possible parameters, which ember-wormhole component can receive and observe them for changes.

If there are other reasons, we can discuss a different fix for the issue.

nlfurniss commented 6 years ago

@dnachev you can fix the travis issues with this: https://github.com/ember-cli/ember-fetch/commit/0a817ff9f80f78a635f16d398e138739308ec52f

dnachev commented 6 years ago

Thanks @nlfurniss . Trying it out.

fivetanley commented 5 years ago

@lukemelia apologies for the direct ping; do you think you or another yapper have some cycles to review+release this?

lukemelia commented 5 years ago

@fivetanley For you, anything :D -- released as 0.5.5

fivetanley commented 5 years ago

@lukemelia <3 quickest merge in the west. thanks!