yapplabs / ember-wormhole

Render a child view somewhere else in the DOM.
MIT License
284 stars 62 forks source link

Emberjs 2.10.0-beta.2 issues #74

Closed adaml881 closed 8 years ago

adaml881 commented 8 years ago

Hi, we're testing the new ember beta and we're seeing a repetition issue with wormhole, the same code works fine on Ember 2.9. Image attached shows the repetition as well as the related console, errors.

Our use of wormhole is quite basic, we have wormhole target divs set up in a right-hand-side bar on application.hbs. The wormholes are populated from a component.

bug

leizhao4 commented 8 years ago

I'm having the same issue when bumping ember-wormhole from 0.4.1 to 0.5.0. I'm on ember 2.10.0-beta.2 too.

When running my acceptance tests:

        message: >
            undefined is not an object (evaluating 'this._dom.document.createTextNode')
        stack: >
            init@http://localhost:7357/assets/vendor.js:181807:50
            superWrapper@http://localhost:7357/assets/vendor.js:54853:27
            Class@http://localhost:7357/assets/vendor.js:50549:22
            create@http://localhost:7357/assets/vendor.js:50837:19
            create@http://localhost:7357/assets/vendor.js:27353:35
            evaluate@http://localhost:7357/assets/vendor.js:62043:43
            execute@http://localhost:7357/assets/vendor.js:68519:36
            render@http://localhost:7357/assets/vendor.js:68093:30
            render@http://localhost:7357/assets/vendor.js:26639:52
            runInTransaction@http://localhost:7357/assets/vendor.js:37601:28
            _renderRoots@http://localhost:7357/assets/vendor.js:26904:64
            _renderRootsTransaction@http://localhost:7357/assets/vendor.js:26942:26
            _renderRoot@http://localhost:7357/assets/vendor.js:26863:35
            _appendDefinition@http://localhost:7357/assets/vendor.js:26776:23
            appendOutletView@http://localhost:7357/assets/vendor.js:26759:29
            invoke@http://localhost:7357/assets/vendor.js:15773:19
            flush@http://localhost:7357/assets/vendor.js:15843:15
            flush@http://localhost:7357/assets/vendor.js:15967:20
            end@http://localhost:7357/assets/vendor.js:16037:28
            run@http://localhost:7357/assets/vendor.js:16160:19
            run@http://localhost:7357/assets/vendor.js:36818:32
            visit@http://localhost:7357/assets/vendor.js:53369:22
            http://localhost:7357/assets/vendor.js:52835:24
            isolate@http://localhost:7357/assets/vendor.js:53961:30
            http://localhost:7357/assets/vendor.js:53917:23
            tryCatch@http://localhost:7357/assets/vendor.js:73179:20
            invokeCallback@http://localhost:7357/assets/vendor.js:73191:21
            publish@http://localhost:7357/assets/vendor.js:73162:21
            http://localhost:7357/assets/vendor.js:52853:24
            invoke@http://localhost:7357/assets/vendor.js:15775:18
            flush@http://localhost:7357/assets/vendor.js:15843:15
            flush@http://localhost:7357/assets/vendor.js:15967:20
            end@http://localhost:7357/assets/vendor.js:16037:28
            run@http://localhost:7357/assets/vendor.js:16160:19
            run@http://localhost:7357/assets/vendor.js:36818:32
            http://localhost:7357/assets/vendor.js:53442:24

Hope it helps.

adam-knights commented 8 years ago

@chadhietala would seem that the new getDom function is providing a _dom without a document property. Is this a bug with Glimmer 2 itself?

ghost commented 8 years ago

saw identical stack trace when running ember 2.10.0-beta.3 and ember-wormhole@0.5.0